Re: [helm/charts] [incubator/vault] Add ability to configure liveness/readiness probe thresholds (#23282)

From: notifications@github.com
Domain: IP info github.com
MX-server: IP info out-21.smtp.github.com
Size: 2290 Bytes
Create: 2020-07-23
Update: 2020-07-23
Score: 0
Safe: Yes

Outbound domains: github.com |

@jbialy commented on this pull request.


In incubator/vault/templates/deployment.yaml:

> +          failureThreshold: {{ .Values.vault.readiness.failureThreshold }}
+          successThreshold: {{ .Values.vault.readiness.successThreshold }}
+          timeoutSeconds: {{ .Values.vault.readiness.timeoutSeconds }}

How about making these values the default unless overridden?

⬇️ Suggested change
-          failureThreshold: {{ .Values.vault.readiness.failureThreshold }}
-          successThreshold: {{ .Values.vault.readiness.successThreshold }}
-          timeoutSeconds: {{ .Values.vault.readiness.timeoutSeconds }}
+          failureThreshold: {{ .Values.vault.readiness.failureThreshold | default 3 }}
+          successThreshold: {{ .Values.vault.readiness.successThreshold | default 1 }}
+          timeoutSeconds: {{ .Values.vault.readiness.timeoutSeconds | default 1 }}

This way we only have to set these in the values.yaml when needed?


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

Want to protect your real email from messages like this? Use TempM email and be more secure on the internet.