Re: [helm/charts] incubator/kube-downscaler - Expand configuration options for service account (#23058)

From: notifications@github.com
Domain: IP info github.com
MX-server: IP info out-20.smtp.github.com
Size: 5557 Bytes
Create: 2020-07-09
Update: 2020-07-13
Score: 0
Safe: Yes

Outbound domains: github.com |

@Pluies requested changes on this pull request.

Agree on the breaking character of the change. Is it okay ot up major version, considering the chart is in pre-release (major version 0)? https://semver.org/#how-do-i-know-when-to-release-100

I guess that makes sense, especially because we're in the incubator part of the charts :)

The imagePullSecrets part looks fine. πŸ‘

Just a couple of notes on this PR and this is mergeable!


In incubator/kube-downscaler/README.md:

> +| `name`                       | How to name resources created by this chart                                                             | `kube-downscaler`             |
+| `debug.enable`               | Do you want to start the downscaler in debug mode                                                       | `false`                       |
+| `namespace.active_in`        | Which namespace does the downscaler scans for deployment/statefulsets to downscale (`''` equals all) | `''`                          |
+| `interval`                   | Interval between scans, in seconds                                                                      | `60`                          |
+| `image.repository`           | Downscaler container image repository                                                                   | `hjacobs/kube-downscaler`     |
+| `image.tag`                  | Downscaler container image tag                                                                          | `19.10.1`                     |
+| `image.pullPolicy`           | Downscaler container image pull policy                                                                  | `IfNotPresent`                |
+| `nodeSelector`               | Node labels for downscaler pod assignment                                                               | `{}`                          |
+| `tolerations`                | Downscaler pod toleration for taints                                                                    | `[]`                          |
+| `affinity`                   | Downscaler pod affinity                                                                                 | `{}`                          |
+| `podAnnotations`             | Annotations to be added to downscaler pod                                                               | `{}`                          |
+| `podLabels`                  | Labels to be added to downscaler pod                                                                    | `{}`                          |
+| `resources`                  | Downscaler pod resource requests & limits                                                               | `{}`                          |
+| `securityContext`            | SecurityContext to apply to the downscaler pod                                                          | `{}`                          |
+| `rbac.create`                | If true, create & use RBAC resources                                                                    | `true`                        |
+| `serviceAccount.create`      | If true, create & use a ServiceAccount                                                                  | `""`                          |

The default here should be true


In incubator/kube-downscaler/templates/serviceaccount.yaml:

>  apiVersion: v1
 kind: ServiceAccount
 metadata:
-  name: {{ include "kube-downscaler.fullname" . }}
+  name: {{ include "kube-downscaler.serviceAccountName" . }}
+  namespace: {{ .Release.Namespace }}

Is this line needed? πŸ€” I would think it creates resources in the release namespace by default.

β€”
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

Want to protect your real email from messages like this? Use TempM email and be more secure on the internet.