Re: [helm/charts] [stable/prometheus-mongodb-exporter] Possibility to also add a custom key in the existing secret (#23262)

From: notifications@github.com
Domain: IP info github.com
MX-server: IP info o4.sgmail.github.com
Size: 2109 Bytes
Create: 2020-07-20
Update: 2020-07-20
Score: 0
Safe: Yes

Outbound domains: github.com |

@steven-sheehy requested changes on this pull request.


In stable/prometheus-mongodb-exporter/values.yaml:

> @@ -32,6 +32,7 @@ mongodb:
 # If this is provided, the value mongodb.uri is ignored.
 existingSecret:
   name: ""
+  key: ""

Just put "mongodb-uri" as default here and in README


In stable/prometheus-mongodb-exporter/templates/_helpers.tpl:

> \ No newline at end of file
+{{- end -}}
+
+{{/*
+Determine secret key, can either be the self-created of an existing one
+*/}}
+{{- define "prometheus-mongodb-exporter.secretKey" -}}

Don't think this function is necessary. Can simplify with a default in values.yaml and use {{ .Values.existingSecret.key }} in manifests


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

Want to protect your real email from messages like this? Use TempM email and be more secure on the internet.