Re: [helm/charts] [stable/datadog] Handle arguments in the cluster-agent command (#22922)

From: notifications@github.com
Domain: IP info github.com
MX-server: IP info out-22.smtp.github.com
Size: 3221 Bytes
Create: 2020-06-25
Update: 2020-06-26
Score: 0
Safe: Yes

Outbound domains: github.com |

Indeed, with the current version overriding the command
either in the values:

  command: ["agent", "start"]

or in the command directly:
--set clusterAgent.command[0]=agent --set clusterAgent.command[1]=start

      - name: cluster-agent
        image: "datadog/cluster-agent:1.6.0"
        command: [agent start]
        imagePullPolicy: IfNotPresent
        resources:
          {}
        ports:

Which does not work.

With the new logic, for the same values.yaml or --set we have:

        image: "datadog/cluster-agent:1.6.0"
        command:
          - "agent"
          - "start"

we're resilient to the quotes as well.

I have seen a few use cases where users move files around before starting however (the proper way to handle this would be through an init container). But I could see the feature request coming in the future to support the args:

      - args:
        - -c
        - echo "test"; agent start
        command:
        - /bin/bash

which is not possible at the moment. Let's do that in another PR as this is a fix.


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

Want to protect your real email from messages like this? Use TempM email and be more secure on the internet.