Re: [STEllAR-GROUP/hpx] Adding performance counter type information (#4441)

From: notifications@github.com
Domain: IP info github.com
MX-server: IP info out-27.smtp.github.com
Size: 1999 Bytes
Create: 2020-03-26
Update: 2020-03-27
Score: 1
Safe: Yes

Outbound domains: github.com |

@msimberg requested changes on this pull request.


In examples/apex/apex_policy_engine_active_thread_count.cpp:

>  }
 
 void setup_counters() {
     try {
-        id_type id = get_counter_id();
+        performance_counter counter = get_counter();
         // We need to explicitly start all counters before we can use them. For
         // certain counters this could be a no-op, in which case start will
         // return 'false'.
         performance_counter::start(hpx::launch::sync, id);
⬇️ Suggested change
-        performance_counter::start(hpx::launch::sync, id);
+        counter.start(hpx::launch::sync, id);

I think?


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

Want to protect your real email from messages like this? Use TempM email and be more secure on the internet.