Re: [ray-project/ray] [tune] Fault tolerance improvements (#5877)

From: notifications@github.com
Domain: IP info github.com
MX-server: IP info out-17.smtp.github.com
Size: 2242 Bytes
Create: 2019-11-11
Update: 2019-11-11
Score: 0
Safe: Yes

Outbound domains: github.com |

@ujvl commented on this pull request.


In python/ray/tune/ray_trial_executor.py:

>                  error_msg = traceback.format_exc()
                 self._stop_trial(trial, error=True, error_msg=error_msg)
-                # note that we don't return the resources, since they may
-                # have been lost
+                # Note that we don't return the resources, since they may
+                # have been lost.
+                # TODO(ujvl): is this the right thing to do?

agree


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

Want to protect your real email from messages like this? Use TempM email and be more secure on the internet.