Re: [NixOS/nixpkgs] systemd: build with cryptsetup support, add cryptsetup generators (#66856)

From: notifications@github.com
Domain: IP info github.com
MX-server: IP info out-18.smtp.github.com
Size: 2352 Bytes
Create: 2020-05-24
Update: 2020-05-24
Score: 1
Safe: Yes

Outbound domains: github.com |

@flokli commented on this pull request.


In pkgs/os-specific/linux/systemd/default.nix:

> @@ -30,6 +31,10 @@ let gnupg-minimal = gnupg.override {
   zlib = null;
   bzip2 = null;
 };
+
+# to avoid circular dependencies, build cryptsetup with a lvm2 without udev support
+_cryptsetup = cryptsetup.override { lvm2 = lvm2.override { udev = null; }; };

I did dig a bit deeper. cryptsetup really only uses the devmapper library which is shipped with lvm2. So cryptsetup in general is perfectly fine with a lvm2 without udev.

This means, we're perfectly fine building cryptsetup defined in all-packages.nix this way, and I can remove the _cryptsetup here.

I also did some closure slimming by introducing multiple outputs for the lvm2 derivation and disabling the cmdlib library, which only seems to be used to simplify LV management tasks via a web interface (?)


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

Want to protect your real email from messages like this? Use TempM email and be more secure on the internet.