Re: [patternfly/patternfly-react] Use transform imports plugin on react-icons for all pf4 builds. (#3476)

From: notifications@github.com
Domain: IP info github.com
MX-server: IP info out-5.smtp.github.com
Size: 2693 Bytes
Create: 2020-01-16
Update: 2020-01-16
Score: 0
Safe: Yes

Outbound domains: github.com |

@Hyperkid123 commented on this pull request.


In packages/patternfly-4/.babelrc:

> @@ -1,11 +0,0 @@
-{
-  "presets": ["@babel/react"],
-  "ignore": ["**/__snapshots__", "**/*.d.ts", "**/*.test.*"],
-  "plugins": [
-    "@babel/plugin-transform-typescript",
-    "babel-plugin-typescript-to-proptypes",
-    "@babel/plugin-proposal-export-default-from",
-    "@babel/proposal-class-properties",
-    "@babel/proposal-object-rest-spread",
-  ]
-}

If you are planing the direct imports that would be perfect and we can close this. I would prefer that anyway so you don't have to rely on some plugin.

I did not want to do any changes to the component code.

I would like to point out that the same thing should be done with react-core components in extensions like react-table.


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

Want to protect your real email from messages like this? Use TempM email and be more secure on the internet.